Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Handle wsrep_gtid_mode enabled #5

Merged

Conversation

matthieugusmini
Copy link
Contributor

@matthieugusmini matthieugusmini commented Nov 8, 2023

  • Changed the parsing logic of the seqno field in the Galera state file
  • Added a struct to serialize/deserialize the GTID tied to the sequence number
  • Updated the unit tests

Relevant documentation:

- Changed the parsing logic of the seqno field in the Galera state file
- Added a struct to serialize/deserialize the GTID tied to the sequence number
- Updated the unit tests
Copy link
Member

@mmontes11 mmontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort investigating this bug and the implementation of the fix 💯

Tests are failing, left a suggestion which might probably fix it

pkg/galera/gtid_test.go Outdated Show resolved Hide resolved
pkg/galera/galera.go Show resolved Hide resolved
@mmontes11 mmontes11 self-requested a review November 13, 2023 17:22
Copy link
Member

@mmontes11 mmontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🙏🏻

I will release a v0.0.4-beta1 to test it together with the operator. Would you mind bumping the agent to this version in the mariadb-operator version and raise a PR?

@mmontes11 mmontes11 merged commit b1f9ef6 into mariadb-operator:main Nov 13, 2023
4 checks passed
@matthieugusmini matthieugusmini deleted the handle-wsrep-gtid-mode branch November 14, 2023 02:26
matthieugusmini pushed a commit to matthieugusmini/mariadb-operator that referenced this pull request Nov 14, 2023
Upgraded the agent version to v0.0.4-beta1.
See mariadb-operator/agent#5 (review)
matthieugusmini pushed a commit to matthieugusmini/mariadb-operator that referenced this pull request Nov 14, 2023
Upgraded the agent version to v0.0.4-beta1.
See mariadb-operator/agent#5 (review)
matthieugusmini pushed a commit to matthieugusmini/mariadb-operator that referenced this pull request Nov 15, 2023
Upgraded the agent version to v0.0.4-beta1.
See mariadb-operator/agent#5 (review)
matthieugusmini pushed a commit to matthieugusmini/mariadb-operator that referenced this pull request Nov 15, 2023
Upgraded the agent version to v0.0.4-beta1.
See mariadb-operator/agent#5 (review)
matthieugusmini pushed a commit to matthieugusmini/mariadb-operator that referenced this pull request Nov 20, 2023
Upgraded the agent version to v0.0.4-beta2.
See mariadb-operator/agent#5 (review)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants