Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add institutional stake #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add institutional stake #152

wants to merge 2 commits into from

Conversation

butonium
Copy link
Contributor

@butonium butonium commented Nov 29, 2024 •
edited
Loading

DO NOT MERGE

@ochaloup ochaloup self-requested a review December 3, 2024 09:51
ochaloup
ochaloup requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ochaloup ochaloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about assert in the collect code.

Small nitpick:
I believe there is missing an item within the api/src/handlers/config.rs to provide info on institutional delegation authority.

collect/src/marinade_service.rs Outdated

assert!(
!institutional_stakes.is_empty(),
"Failed to fetch institutional stake data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is correct to expect there will be always some institutional stake?

ochaloup
ochaloup approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@ochaloup ochaloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. All good seems to me.

@ochaloup
Copy link
Contributor

ochaloup commented Dec 4, 2024

NOTE FOR A READER the PR merging is postponed to be coordinated with other changes for institutional delegation strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochaloup ochaloup ochaloup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonium @ochaloup