Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Marinade native support #3

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

MjCage
Copy link

@MjCage MjCage commented Sep 22, 2023

This is for internal reviewing purposes only!!

DO NOT MERGE!

The PR can be tested with the following DAOs using our shared testing wallet:
Devnet: http://localhost:3000/dao/E86rHKBMeKd3FUF7NeL5TFivQYnXC9f7eCcGkkWjgBYQ?cluster=devnet
Mainnet: http://localhost:3000/dao/EfRSksHiDzHxrvYvMohA89wTFNbtwWcg3pECQQ9JhTGn

@MjCage MjCage requested a review from AlexStefan September 22, 2023 07:19
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9ce4c7
Status:🚫  Build failed.

View logs

Copy link

@AlexStefan AlexStefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! few small things to tackle:

package.json Outdated Show resolved Hide resolved
stores/useGovernanceAssetsStore.tsx Outdated Show resolved Hide resolved
stores/useGovernanceAssetsStore.tsx Outdated Show resolved Hide resolved
utils/instructionTools.ts Outdated Show resolved Hide resolved
utils/instructionTools.ts Outdated Show resolved Hide resolved
utils/validations.tsx Outdated Show resolved Hide resolved
@MjCage MjCage force-pushed the feat/marinade-native-support branch from c19d808 to 6db1568 Compare September 25, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants