Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL rebase (fixes #39) #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgreter
Copy link

@mgreter mgreter commented Oct 26, 2016

This change would fix the issues I'm having in #39.
Not sure if this is sane or changing usefull old behavior!

Edit: refactored the fix a little bit more.

Btw. npm test does not work on windows:

> [email protected] test D:\github-forks\gulp-concat-css
> node_modules/mocha/bin/mocha test/*.js --reporter spec

'node_modules' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! Test failed.  See above for more details.

Had to use node node_modules\mocha\bin\mocha --reporter spec

@antur84
Copy link

antur84 commented Mar 15, 2017

Thanks, this also solved a very similar issue we were facing, it did not introduce any known new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants