Fix bugs that appear with small or empty mini batch neighborhoods #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the build/install which we worked to improve and should be stable (using the docker file instructions) as of #131. We should work to make the "Build and Test" check more stable so that it doesn't fail every new PR as dependencies etc. change, but that is beyond the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bugs in the main branch that cause the system to crash when small batches have a few or zero total neighbors. These bugs often appear when running disk-based training, especially as the in-memory subgraph gets sparser with small buffer capacities relative to the number of partitions. This PR fixes these issues.