Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27 command history #71

Merged
merged 2 commits into from
Sep 16, 2018
Merged

27 command history #71

merged 2 commits into from
Sep 16, 2018

Conversation

markbirbeck
Copy link
Owner

Closes #27.

@kaste @markbirbeck
[#27] Remember history of commands
725aab5 
Prefills input panel with the most recent command. The user can navigate
the history with arrow up and down keys.
@kaste @markbirbeck
[#27] Initial input must be a string
0857680
@markbirbeck markbirbeck self-assigned this Sep 16, 2018
@markbirbeck
Copy link
Owner Author

Damn...was just about to merge this and discovered two bugs:

  • the first is minor, which is that when the prompt is opened it takes two presses of either up or down to get the history started;
  • the second is a little bit different and involves every command that is run being added to the history, not just commands that are executed via the [ALT]+! and [ALT]+| sequences.

@markbirbeck markbirbeck merged commit e635c5e into master Sep 16, 2018
@markbirbeck markbirbeck deleted the 27-command-history branch September 16, 2018 21:43
@markbirbeck
Copy link
Owner Author

I've merged this, and opened issues to reflect the two problems outlined (#72 and #73).

@markbirbeck markbirbeck mentioned this pull request Sep 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markbirbeck markbirbeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markbirbeck @kaste