Skip to content

Commit

Permalink
Make the JVM get pid 1 to allow graceful shutdown
Browse files Browse the repository at this point in the history
  • Loading branch information
tsegismont authored and cescoffier committed Sep 28, 2016
1 parent 8353bef commit 32831b1
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ COPY ./verticles $VERTICLE_HOME

# We use the "sh -c" to turn around https://github.com/docker/docker/issues/5509 - variable not expanded
ENTRYPOINT ["sh", "-c"]
CMD ["vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/* $VERTX_OPTIONS"]
CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/* $VERTX_OPTIONS"]

2 changes: 1 addition & 1 deletion docker-examples/vertx-docker-groovy/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ COPY $VERTICLE_NAME $VERTICLE_HOME/
# Launch the verticle <5>
WORKDIR $VERTICLE_HOME
ENTRYPOINT ["sh", "-c"]
CMD ["vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
2 changes: 1 addition & 1 deletion docker-examples/vertx-docker-java-fatjar/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ COPY target/$VERTICLE_FILE $VERTICLE_HOME/
# Launch the verticle
WORKDIR $VERTICLE_HOME
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $VERTICLE_FILE"]
CMD ["exec java -jar $VERTICLE_FILE"]
2 changes: 1 addition & 1 deletion docker-examples/vertx-docker-java/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ COPY $VERTICLE_FILE $VERTICLE_HOME/
# Launch the verticle
WORKDIR $VERTICLE_HOME
ENTRYPOINT ["sh", "-c"]
CMD ["vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
2 changes: 1 addition & 1 deletion docker-examples/vertx-docker-javascript/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ COPY $VERTICLE_NAME $VERTICLE_HOME/
# Launch the verticle <5>
WORKDIR $VERTICLE_HOME
ENTRYPOINT ["sh", "-c"]
CMD ["vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
2 changes: 1 addition & 1 deletion docker-examples/vertx-docker-ruby/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ COPY $VERTICLE_NAME $VERTICLE_HOME/
# Launch the verticle <5>
WORKDIR $VERTICLE_HOME
ENTRYPOINT ["sh", "-c"]
CMD ["vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
CMD ["exec vertx run $VERTICLE_NAME -cp $VERTICLE_HOME/*"]
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ RUN chmod 777 /app/

WORKDIR /app/
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $JAVA_APP_JAR -cluster"]
CMD ["exec java -jar $JAVA_APP_JAR -cluster"]
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ RUN chmod 777 /app/

WORKDIR /app/
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $JAVA_APP_JAR -cluster"]
CMD ["exec java -jar $JAVA_APP_JAR -cluster"]
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ RUN chmod 777 /app/

WORKDIR /app/
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $JAVA_APP_JAR"]
CMD ["exec java -jar $JAVA_APP_JAR"]
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ RUN chmod 777 /app/

WORKDIR /app/
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $JAVA_APP_JAR"]
CMD ["exec java -jar $JAVA_APP_JAR"]
2 changes: 1 addition & 1 deletion openshift3-examples/simple-web-application/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ RUN chmod 777 /app/

WORKDIR /app/
ENTRYPOINT ["sh", "-c"]
CMD ["java -jar $JAVA_APP_JAR"]
CMD ["exec java -jar $JAVA_APP_JAR"]

0 comments on commit 32831b1

Please sign in to comment.