Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid circular references #16

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

@DylanPiercey DylanPiercey force-pushed the avoid-circular-references-for-define-component branch from feeb897 to 261aba9 Compare October 26, 2023 15:25
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (021b5e2) 88.03% compared to head (261aba9) 88.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   88.03%   88.03%   -0.01%     
==========================================
  Files          55       55              
  Lines        4790     4798       +8     
  Branches      719      722       +3     
==========================================
+ Hits         4217     4224       +7     
- Misses        551      552       +1     
  Partials       22       22              
Files Coverage Δ
...rko-widgets/src/components/widget-types/migrate.ts 72.72% <0.00%> (ø)
packages/marko-widgets/src/migrate/w-bind.ts 89.79% <95.45%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 64b841c into main Oct 26, 2023
6 of 7 checks passed
@DylanPiercey DylanPiercey deleted the avoid-circular-references-for-define-component branch October 26, 2023 15:30
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant