Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add for tag by attribute types #229

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: add for tag by attribute types #229

merged 1 commit into from
Dec 11, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Resolves #228

Motivation and Context

Currently because of the special transformations we have to do on control flow tags their types exist in this project.
However the by attribute for <for> tags in the tags api was missed.

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: a78bf95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/language-server Patch
@marko/language-tools Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 6c7e1a9 into main Dec 11, 2023
4 checks passed
@DylanPiercey DylanPiercey deleted the for-tag-by-types branch December 11, 2023 16:34
@DylanPiercey DylanPiercey self-assigned this Dec 11, 2023
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to type-check <for/> tag
1 participant