fix(ts): type narrowing in forOfAttrTag function #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, type expansion broke this type:
because instead of
"small" | "large"
, the type lost its specificity and propagated asstring
.This
const
prevents working code from throwing type errors, but it doesn't fix the long-winded error that it shown in addition to the very precise error when an invalid type is included (see snapshot examples). We should look into a way to filter out the big error when we know the small and direct one will exist.