Merge pull request #62 from marko-js/59-input-dependency

fix: input dependencies with compiler update

.changeset/gentle-cars-repeat.md

@@ -0,0 +1,5 @@
+---
+"@marko/tags-api-preview": patch
+---
+
+Fix input dependency tracking

.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
       - name: Use node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
           cache: npm
       - name: Install dependencies
         run: npm ci

src/__tests__/fixtures/effect/__snapshots__/effect-read-input/node.render.expected.html

@@ -0,0 +1 @@
+1

src/__tests__/fixtures/effect/__snapshots__/effect-read-input/web.render.expected.html

@@ -0,0 +1 @@
+1

src/__tests__/fixtures/effect/__snapshots__/effect-read-input/web.step-0.expected.html

@@ -0,0 +1 @@
+2

src/__tests__/fixtures/effect/index.test.ts

@@ -79,6 +79,24 @@ describe(
   ]),
 );
 
+describe(
+  "<effect> read-input",
+  fixture("./templates/read-input.marko", [
+    { onCount, count: 1 },
+    async ({ expect, rerender }) => {
+      expect(onCount).calledOnceWith(1);
+      resetHistory();
+
+      await rerender();
+      expect(onCount).has.not.been.called;
+
+      await rerender({ onCount, count: 2 });
+      expect(onCount).calledOnceWith(2);
+      resetHistory();
+    },
+  ]),
+);
+
 describe(
   "<effect> multiple",
   fixture("./templates/multiple.marko", [

src/__tests__/fixtures/effect/templates/read-input.marko

@@ -0,0 +1,5 @@
+<effect() {
+  input.onCount(input.count);
+}/>
+
+-- ${input.count}

src/transform/cached-values/transform.ts

@@ -47,12 +47,13 @@ const depsVisitor = {
 
     if (
       binding
-        ? binding.path.isMarkoTag() &&
-          !(
-            binding.path === state.parentTag ||
-            isNativeTag(binding.path) ||
-            isDynamicTag(binding.path)
-          )
+        ? binding.path.isMarkoTag()
+          ? !(
+              binding.path === state.parentTag ||
+              isNativeTag(binding.path) ||
+              isDynamicTag(binding.path)
+            )
+          : name === "input" && binding.path.isProgram()
         : name === "input" || name === "$global"
     ) {
       let deps = state.deps || (state.deps = {});