Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basePathVar and runtimeId options #101

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: c69de0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0aacc63) 74.59% compared to head (c69de0f) 74.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          10       10           
  Lines         248      248           
  Branches       48       48           
=======================================
  Hits          185      185           
  Misses         45       45           
  Partials       18       18           
Files Coverage Δ
src/render-assets-runtime.ts 71.42% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 0601f65 into main Nov 13, 2023
7 of 8 checks passed
@DylanPiercey DylanPiercey deleted the fix-base-path-regression branch November 13, 2023 19:28
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant