Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #117

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Various updates #117

merged 7 commits into from
Apr 11, 2024

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Apr 3, 2024

Description

  • Support css-loader imports (eg. remove ~ prefixes)
  • Only transform transform relative src attributes for asset types that Vite doesn't transform (eg. exclude js/css) or if the path includes ?url
  • Use the env var BASE_URL as config.base when it is not set

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 536dce5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (53e1bd4) to head (cc0dc4e).
Report is 3 commits behind head on main.

❗ Current head cc0dc4e differs from pull request most recent head 536dce5. Consider uploading reports for the commit 536dce5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   72.22%   72.27%   +0.05%     
==========================================
  Files          11       11              
  Lines         648      660      +12     
  Branches      156      162       +6     
==========================================
+ Hits          468      477       +9     
  Misses        123      123              
- Partials       57       60       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq force-pushed the css-loader-import branch from cc0dc4e to f82cfb6 Compare April 11, 2024 21:01
@rturnq rturnq force-pushed the css-loader-import branch from f82cfb6 to 536dce5 Compare April 11, 2024 21:07
@rturnq rturnq merged commit 7a3a5e6 into main Apr 11, 2024
7 checks passed
@rturnq rturnq deleted the css-loader-import branch April 11, 2024 21:11
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant