Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle asset imports from cjs lib marko files #120

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Apr 11, 2024

Description

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 1280e8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rturnq rturnq force-pushed the better-cjs-handling branch from 5d4dd20 to 1280e8e Compare April 11, 2024 20:58
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.31%. Comparing base (53e1bd4) to head (1280e8e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   72.22%   73.31%   +1.09%     
==========================================
  Files          11       11              
  Lines         648      637      -11     
  Branches      156      155       -1     
==========================================
- Hits          468      467       -1     
+ Misses        123      114       -9     
+ Partials       57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq merged commit 90cca62 into main Apr 11, 2024
9 checks passed
@rturnq rturnq deleted the better-cjs-handling branch April 11, 2024 21:02
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant