Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR assets #162

Merged
merged 5 commits into from
Nov 20, 2024
Merged

SSR assets #162

merged 5 commits into from
Nov 20, 2024

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Nov 20, 2024

Description

Assets imported only in the SSR build are now collected and forwarded to the client build to be emitted

Bonus

  • Add client error logging to tests
  • Join all loading and step test snapshots into a single markdown file to prevent false negatives when a step is not longer created.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: d4b19ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 942c22e into main Nov 20, 2024
7 checks passed
@DylanPiercey DylanPiercey deleted the ssr-assets branch November 20, 2024 19:24
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants