Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJS imports in Marko files(SSR) #94

Merged
merged 7 commits into from
Nov 7, 2023
Merged

CJS imports in Marko files(SSR) #94

merged 7 commits into from
Nov 7, 2023

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Nov 6, 2023

Description

This PR enables better interop between Marko files and CJS imports in SSR builds. Specifically, this change should allow using named imports from files using module.exports.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: 6e2d3e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (04504ce) 76.53% compared to head (6e2d3e4) 76.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   76.53%   76.53%   -0.01%     
==========================================
  Files           9       11       +2     
  Lines         537      588      +51     
  Branches      120      135      +15     
==========================================
+ Hits          411      450      +39     
- Misses         81       89       +8     
- Partials       45       49       +4     
Files Coverage Δ
src/index.ts 74.41% <100.00%> (-0.02%) ⬇️
src/babel-plugin-cjs-interop.ts 74.07% <74.07%> (ø)
src/resolve.ts 78.12% <78.12%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq merged commit 1096959 into main Nov 7, 2023
9 of 10 checks passed
@rturnq rturnq deleted the cjs-interop branch November 7, 2023 17:06
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant