fix: append pending inline text only after unblocked #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ately during close if blocked This fixes an issue where an inline host node would remain empty if it was the last node in the tree and a blocking node was encountered.
The committers listed above are authorized under a signed CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where an inline host node would remain empty if it was the last node in the tree and a blocking node was encountered.
Motivation and Context
Previously, the final attempt to append inline text would happen immediately once the writable stream is closed. However, there can potentially be more pending inline text added to the buffer if the writer is currently blocked waiting on an external resource. This text will never be written.
Instead, we should defer the final write until after we've become unblocked.
Checklist:
The current architecture of the test fixtures makes it difficult to reproduce the existing issue in a test case because the writer is only closed after all fixture steps are executed.