Merge pull request Shopify#80 from timrourke/feature/add-draggable-tests

Feature/add draggable tests
marksouthard · Jan 10, 2018 · a3e74c6 · a3e74c6
2 parents 1bd10f0 + 05c77b1
commit a3e74c6
Show file tree

Hide file tree

Showing 3 changed files with 659 additions and 14 deletions.
diff --git a/scripts/test/helper.js b/scripts/test/helper.js
@@ -74,3 +74,40 @@ export function triggerEvent(element, type, data = {}) {
   element.dispatchEvent(event);
   return event;
 }
+
+/**
+ * A stub of the Plugin class
+ *
+ * @class PluginStub
+ */
+export class PluginStub {
+
+  /**
+   * Constructor.
+   *
+   * @param {Draggable} draggable
+   */
+  constructor(draggable) {
+    this.attachWasCalled = false;
+    this.detachWasCalled = false;
+    this.draggable = draggable;
+    this.numTimesAttachCalled = 0;
+    this.numTimesDetachCalled = 0;
+  }
+
+  /**
+   * Set a testable property when `attach` is called
+   */
+  attach() {
+    this.attachWasCalled = true;
+    this.numTimesAttachCalled++;
+  }
+
+  /**
+   * Set a testable property when `detach` is called
+   */
+  detach() {
+    this.detachWasCalled = true;
+    this.numTimesDetachCalled++;
+  }
+}
diff --git a/src/Draggable/Draggable.js b/src/Draggable/Draggable.js
@@ -36,7 +36,7 @@ const onDragStop = Symbol('onDragStop');
 const onDragPressure = Symbol('onDragPressure');
 const getAppendableContainer = Symbol('getAppendableContainer');
 
-const defaults = {
+export const defaultOptions = {
   draggable: '.draggable-source',
   handle: null,
   delay: 100,
@@ -83,7 +83,7 @@ export default class Draggable {
       throw new Error('Draggable containers are expected to be of type `NodeList`, `HTMLElement[]` or `HTMLElement`');
     }
 
-    this.options = {...defaults, ...options};
+    this.options = {...defaultOptions, ...options};
     this.callbacks = {};
 
     /**
@@ -279,7 +279,7 @@ export default class Draggable {
    * @return {String|null}
    */
   getClassNameFor(name) {
-    return this.options.classes[name] || defaults.classes[name];
+    return this.options.classes[name] || defaultOptions.classes[name];
   }
 
   /**