Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oyster cvm doctor and build #19

Merged
merged 14 commits into from
Dec 24, 2024
Merged

add oyster cvm doctor and build #19

merged 14 commits into from
Dec 24, 2024

Conversation

Naman-Monga
Copy link
Contributor

No description provided.

@roshanrags roshanrags requested a review from vg-27 December 17, 2024 08:00
@roshanrags
Copy link
Member

add a readme

cli/oyster-cvm/.gitignore Outdated Show resolved Hide resolved
cli/oyster-cvm/src/commands/doctor.rs Outdated Show resolved Hide resolved
cli/oyster-cvm/src/commands/build.rs Show resolved Hide resolved
cli/oyster-cvm/src/commands/build.rs Outdated Show resolved Hide resolved
cli/oyster-cvm/Readme.md Outdated Show resolved Hide resolved
cli/oyster-cvm/Readme.md Outdated Show resolved Hide resolved
@roshanrags
Copy link
Member

use tracing for logs btw

Comment on lines 9 to 10
log = "0.4"
env_logger = "0.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy the readme format from other stuff ig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check now.

}

#[derive(Parser)]
#[command(about = "AWS Nitro Enclave Image Builder")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it "Oyster CVM command line utility" or smth

@roshanrags
Copy link
Member

roshanrags commented Dec 24, 2024

Has it been tested? If so, good to go.

@roshanrags roshanrags merged commit 3e6dbc8 into master Dec 24, 2024
@roshanrags roshanrags deleted the oyster-cli branch December 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants