Ability to convert numbers to numeral adverbs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice', 'thrice', 'four times', etc.
|
Any thoughts on the PR? @marlun78 |
RicoNowCM
reviewed
Dec 27, 2023
| if (numeralAdverbsLessThanFour.hasOwnProperty(words) && (number !== 3 || !ignoreThrice)) { | ||
| return numeralAdverbsLessThanFour[words]; | ||
| } else { | ||
| return words + ' times'; |
There was a problem hiding this comment.
1 - One times <------------
2 - Two times
3 - Three times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeral adverbs are words like 'once', 'twice', 'thrice', and 'four times.'
Was looking for a library that did this, but couldn't find one. I thought: why not add the capability to this existing project! It can expand on the existing ordinal numbers capabilities already here. Let me know what you think, or if you have any suggestions.
Thanks!