Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-admin v5 #61

Merged
merged 12 commits into from
Jun 28, 2024
Merged

Upgrade to react-admin v5 #61

merged 12 commits into from
Jun 28, 2024

Conversation

mrkpatchaa
Copy link
Contributor

@mrkpatchaa mrkpatchaa commented Jun 21, 2024

Marked as a WIP because I can't test locally, and installing npm from my github is not working.
Fixes #60

@mrkpatchaa mrkpatchaa mentioned this pull request Jun 21, 2024
@slax57
Copy link
Contributor

slax57 commented Jun 25, 2024

Thanks for initializing this PR!

I'll try to take over to see if I can finish the migration.

I'll also need to do some more checks to ensure ra-data-postgrest is fully compatible with RA v5 (in which case I'll open a PR to fix the peer dependencies declaration).

@slax57 slax57 added the WIP label Jun 25, 2024
@mrkpatchaa
Copy link
Contributor Author

Great. Looking forward to hearing from you.

@slax57
Copy link
Contributor

slax57 commented Jun 25, 2024

PR to update ra-data-postgrest's peerDeps: raphiniert-com/ra-data-postgrest#142

@slax57 slax57 changed the title [WIP] Upgrade to react-admin v5 Upgrade to react-admin v5 Jun 27, 2024
@slax57 slax57 added RFR and removed WIP labels Jun 27, 2024
@slax57
Copy link
Contributor

slax57 commented Jun 27, 2024

PR is all green! ✅
Just waiting to see with the team if this needs to be merged on the main branch or the next branch. Stay tuned.

@slax57 slax57 added this to the 3.0.0 milestone Jun 27, 2024
@slax57
Copy link
Contributor

slax57 commented Jun 28, 2024

We can merge on master. However the 3.0.0 release will have to wait for either raphiniert-com/ra-data-postgrest#142 to get merged, or for us to fork and release ra-data-postgrest.

@slax57 slax57 merged commit f5dfe6d into marmelab:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to RA 5?
3 participants