Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #652 #653

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix #652 #653

merged 4 commits into from
Jan 30, 2025

Conversation

csbrasnett
Copy link
Collaborator

@csbrasnett csbrasnett commented Jan 29, 2025

raise helpful error if dssp executable is not found. Can easily happen if -dssp is given with no path (i.e. user expects to use MDTraj dssp functionality) but MDTraj is not installed in the python environment. Will fix #652

Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, looks good to me otherwise!

vermouth/tests/test_dssp.py Outdated Show resolved Hide resolved
Co-authored-by: Peter C Kroon <[email protected]>
@pckroon pckroon merged commit 5982e5b into master Jan 30, 2025
10 checks passed
@pckroon pckroon deleted the fix-#652 branch January 30, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle missing dssp error better
2 participants