Remove leaky lru_cache (#2277)

* Remove leaky lru_cache * Update changelog --------- Co-authored-by: Steven Loria <[email protected]>
marshmallow-code · Jun 6, 2024 · 99103a6 · 99103a6
1 parent 47205b5
commit 99103a6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -174,3 +174,4 @@ Contributors (chronological)
 - Aditya Tewary `@aditkumar72 <https://github.com/aditkumar72>`_
 - Sebastien Lovergne `@TheBigRoomXXL <https://github.com/TheBigRoomXXL>`_
 - Peter C `@somethingnew2-0 <https://github.com/somethingnew2-0>`_
+- Marcel Jackwerth `@mrcljx` <https://github.com/mrcljx>`_
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,14 @@
 Changelog
 ---------
 
+3.21.3 (unreleased)
+*******************
+
+Bug fixes:
+
+- Fix memory leak that prevented schema instances from getting GC'd (:pr:`2277`).
+  Thanks :user:`mrcljx` for the PR.
+
 3.21.2 (2024-05-01)
 *******************
 

diff --git a/src/marshmallow/schema.py b/src/marshmallow/schema.py
@@ -13,7 +13,6 @@
 from abc import ABCMeta
 from collections import OrderedDict, defaultdict
 from collections.abc import Mapping
-from functools import lru_cache
 
 from marshmallow import base, class_registry, types
 from marshmallow import fields as ma_fields
@@ -1056,7 +1055,6 @@ def _bind_field(self, field_name: str, field_obj: ma_fields.Field) -> None:
             raise error
         self.on_bind_field(field_name, field_obj)
 
-    @lru_cache(maxsize=8)  # noqa (https://github.com/PyCQA/flake8-bugbear/issues/310)
     def _has_processors(self, tag) -> bool:
         return bool(self._hooks[(tag, True)] or self._hooks[(tag, False)])