Jdt output passthrough #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson [email protected]
grgustaf
force-pushed
the
jdt-output-passthrough
branch
from
a57a77b to
54849ce
Compare
martijnthe
reviewed
Apr 9, 2018
| } else if (code === SP.JERRY_DEBUGGER_CONTINUE) { | ||
| cmd = 'Continue'; | ||
| } | ||
| this.logSentPacket(cmd); |
There was a problem hiding this comment.
Maybe create a logSentCommand(cmd) helper to keep this method here a bit cleaner? Half the lines are about logging now.
|
I'd like to hold off merging this and the other PR until the mother load PR has been merged into the JerryScript project. Once that's done, I think you can just open a new PR directly to the JrS project's Github for this and next PRs. |
|
Yeah, I actually realized over the weekend I didn't really intend to submit these against that branch. :) |
|
But yeah just meant to put them here so you could take a look before I submit them up there (after merge). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.