.NET 8 preparation #1809
Merged
.NET 8 preparation #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
martincostello
commented
Jul 13, 2023
martincostello
commented
- Remove ExcludeByAttribute as it is duplicating the defaults.
- Fix code analysis warning identified in Consume .NET nightly builds #1808.
- Remove ExcludeByAttribute as duplicating the defaults. - Fix code analysis warning identified in #1808.
costellobot
reviewed
Jul 13, 2023
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | https://localhost:5001 |
| Device | URL |
|---|---|
| mobile | https://localhost:5001 |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Exclude code decorated with `[GeneratedCode]` from code coverage.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 153 153
Lines 3309 3309
=======================================
Hits 2840 2840
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.