Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collection expressions #2007

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Use collection expressions #2007

merged 1 commit into from
Oct 23, 2023

Conversation

martincostello
Copy link
Owner

  • Add more usage of C# 12 collection expressions.
  • Remove redundant null checks.

- Add more usage of C# 12 collection expressions.
- Remove redundant null checks.
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels Oct 23, 2023
@martincostello martincostello enabled auto-merge (rebase) October 23, 2023 08:46
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:5001

Device URL
mobile https://localhost:5001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (42f79bc) 79.07% compared to head (3992860) 79.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
+ Coverage   79.07%   79.10%   +0.03%     
==========================================
  Files         153      153              
  Lines        3235     3235              
  Branches      510      509       -1     
==========================================
+ Hits         2558     2559       +1     
  Misses        464      464              
+ Partials      213      212       -1     
Flag Coverage Δ
linux 79.10% <95.65%> (+0.03%) ⬆️
macos 79.10% <95.65%> (?)
windows 79.10% <95.65%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vel.Site/Middleware/CustomHttpHeadersMiddleware.cs 88.31% <100.00%> (ø)
.../LondonTravel.Site/Controllers/ManageController.cs 65.94% <75.00%> (+0.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 173898c into main Oct 23, 2023
12 checks passed
@martincostello martincostello deleted the refactor branch October 23, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants