Skip to content

Commit

Permalink
Use invariant globalisation
Browse files Browse the repository at this point in the history
Use invariant globalisation and remove Microsoft.ICU.ICU4C.Runtime to reduce the AoT deployment size.
  • Loading branch information
martincostello committed Nov 26, 2023
1 parent 750c83a commit 0d7989e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 0 additions & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<PackageVersion Include="Microsoft.Extensions.Http" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
<PackageVersion Include="Microsoft.ICU.ICU4C.Runtime" Version="72.1.0.3" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="Polly.Core" Version="$(PollyVersion)" />
Expand Down
9 changes: 1 addition & 8 deletions src/LondonTravel.Skill/LondonTravel.Skill.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<AWSProjectType>Lambda</AWSProjectType>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<InvariantGlobalization>true</InvariantGlobalization>
<NoWarn>$(NoWarn);CA1822</NoWarn>
<OutputType>Exe</OutputType>
<PublishAot>true</PublishAot>
Expand Down Expand Up @@ -29,12 +30,4 @@
<EmbeddedResource Update="Strings.resx" Generator="ResXFileCodeGenerator" LastGenOutput="Strings.Designer.cs" />
<EmbeddedResource Update="Strings.*.resx" DependentUpon="Strings.resx" />
</ItemGroup>
<ItemGroup Condition=" '$(RuntimeIdentifier)' == 'linux-x64' ">
<PackageReference Include="Microsoft.ICU.ICU4C.Runtime" />
</ItemGroup>
<Target Name="SetAppLocalIcuVersion" BeforeTargets="Compile" Condition=" '$(RuntimeIdentifier)' == 'linux-x64' ">
<ItemGroup>
<RuntimeHostConfigurationOption Condition=" '%(PackageVersion.Identity)' == 'Microsoft.ICU.ICU4C.Runtime' " Include="System.Globalization.AppLocalIcu" Value="%(PackageVersion.Version)" />
</ItemGroup>
</Target>
</Project>

0 comments on commit 0d7989e

Please sign in to comment.