Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AoT friendlier #964

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Make AoT friendlier #964

merged 3 commits into from
Nov 20, 2023

Conversation

martincostello
Copy link
Owner

  • Remove use of Refit to be AoT-friendlier. AoT is not supported though due to trimmer warnings from Newtonsoft.Json (via Alexa.NET) (see AoT Support? timheuer/alexa-skills-dotnet#262) and Microsoft.ApplicationInsights.
  • Bump Newtonsoft.Json to 13.0.3.
  • Group dependabot NuGet package updates for Polly.

Remove use of Refit to be AoT-friendlier.
AoT is not supported though due to trimmer warnings from Newtonsoft.Json (via Alexa.NET) and Microsoft.ApplicationInsights.
Bump Newtonsoft.Json to 13.0.3.
Group NuGet package updates for Polly.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Nov 20, 2023
@martincostello martincostello enabled auto-merge (rebase) November 20, 2023 09:58
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1b4e57) 95.54% compared to head (0b6b01e) 96.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   95.54%   96.98%   +1.43%     
==========================================
  Files          23       24       +1     
  Lines         539      497      -42     
  Branches       62       57       -5     
==========================================
- Hits          515      482      -33     
+ Misses         14        5       -9     
  Partials       10       10              
Flag Coverage Δ
linux ?
macos ?
windows 96.98% <100.00%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 77e0639 into main Nov 20, 2023
11 checks passed
@martincostello martincostello deleted the aot-friendlier branch November 20, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant