Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store architecture in artifact #968

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Conversation

martincostello
Copy link
Owner

Store the architecture in the deployment artifact so that the deployment workflow deploys what it was configured for, not what's defined in the deployment workflow in the main branch.

Store the architecture in the deployment artifact so that the deployment workflow deploys what it was configured for, not what's defined in the deployment workflow in the main branch.
@martincostello martincostello added bug github_actions Pull requests that update GitHub Actions code labels Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3a3857) 96.98% compared to head (9df0a07) 96.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          24       24           
  Lines         497      497           
  Branches       57       57           
=======================================
  Hits          482      482           
  Misses          5        5           
  Partials       10       10           
Flag Coverage Δ
linux 95.97% <ø> (?)
macos 96.98% <ø> (?)
windows 96.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix copy-pasta typo.
Quote the path.
@martincostello martincostello merged commit 61f6cb8 into main Nov 25, 2023
13 checks passed
@martincostello martincostello deleted the deploy-correct-architecture branch November 25, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant