Use JSON console logging #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `MSBUILDTERMINALLOGGER:auto` instead of `--tl`. - Remove hard-coded backslashes. - Use `--jsonfile`/`-JsonFile` and `--skip-non-versioned-files`/`-SkipNonVersionedFiles`.
Use `[]` instead of `Array.Empty<T>()`.
Revert to default xunit test display option.
- Use the .NET JSON console logger. - Filter out logs from Polly.
Remove use of `ILambdaContext` to log and get a logger from DI instead.
martincostello
added
enhancement
dependencies
Use target-typed new to simplify some code.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 96.98% 96.97% -0.01%
==========================================
Files 24 24
Lines 497 496 -1
Branches 57 57
==========================================
- Hits 482 481 -1
Misses 5 5
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/deploy dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILambdaContextto log and get a logger from DI instead.MSBUILDTERMINALLOGGER:autoinstead of--tl.--jsonfile/-JsonFileand--skip-non-versioned-files/-SkipNonVersionedFiles.[]instead ofArray.Empty<T>().