Refactor configuration handling #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify `function-architecture` in the AWS Lambda tools defaults and sort the `function-*` properties.
Use appsettings.json to configure logging instead of code.
Missed from previous commit.
martincostello
added
enhancement
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 96.97% 96.91% -0.07%
==========================================
Files 24 24
Lines 496 486 -10
Branches 57 53 -4
==========================================
- Hits 481 471 -10
Misses 5 5
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Enable the configuration binding source generator.
Apply logging configuration from `IConfiguration`.
For some reason on Linux, the code coverage is 1% less.
Include the `aws-lambda-tools-defaults.json` file in publish so it is included in the Lambda ZIP file so it can be used to configure the Lambda when deployed.
|
/deploy dev |
Read the Lambda settings from `aws-lambda-tools-defaults.json`, rather than multiple copies in the different workflow files.
Fix shellcheck warnings setting up the Lambda settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appsettings.jsonto configure logging instead of code.IConfigurationand remove manual configuration.aws-lambda-tools-defaults.json.