Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card serialization #977

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix card serialization #977

merged 2 commits into from
Nov 29, 2023

Conversation

martincostello
Copy link
Owner

Fix JSON polymorphism so that the additional properties of types derived from Card are serialized.

Fix JSON polymorphism so that the additional properties of types derived from `Card` are serialized.
@martincostello martincostello added bug .NET Pull requests that update .net code labels Nov 29, 2023
@martincostello martincostello enabled auto-merge (rebase) November 29, 2023 13:05
Add a test case for when there's no card in the response.
@martincostello
Copy link
Owner Author

/deploy dev

Copy link

github-actions bot commented Nov 29, 2023

🧪 Tests for deployment to dev passed ✅

@martincostello martincostello merged commit 0d28960 into main Nov 29, 2023
11 checks passed
@martincostello martincostello deleted the fix-responses branch November 29, 2023 13:16
martincostello added a commit that referenced this pull request Dec 2, 2023
Revert #977 to check the tests added by #983 find the bug in the absence of a unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant