Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise for speed #980

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Optimise for speed #980

merged 4 commits into from
Dec 1, 2023

Conversation

martincostello
Copy link
Owner

Optimise AoT for speed and target Amazon Graviton processors.

Requested via Twitter.

Optimise AoT for speed and target Amazon Graviton processors.
@martincostello martincostello marked this pull request as draft November 30, 2023 22:44
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81c94d9) 96.72% compared to head (c1c7089) 96.19%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/LondonTravel.Skill/SkillResponseBuilder.cs 94.73% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   96.72%   96.19%   -0.54%     
==========================================
  Files          45       43       -2     
  Lines         642      552      -90     
  Branches       71       53      -18     
==========================================
- Hits          621      531      -90     
  Misses          7        7              
  Partials       14       14              
Flag Coverage Δ
linux 95.28% <96.29%> (-0.67%) ⬇️
macos 96.19% <96.29%> (-0.54%) ⬇️
windows 96.19% <96.29%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Give native AoT compiler a hint as to which CPU to target for Graviton.
Remove property from project file, otherwise it breaks publishing on macOS and Windows.
@martincostello
Copy link
Owner Author

/deploy dev

Copy link

github-actions bot commented Dec 1, 2023

🧪 Tests for deployment to dev passed ✅

@martincostello
Copy link
Owner Author

martincostello commented Dec 1, 2023

Blended

From #973 (comment):

Package size: 11.6 MB

Duration: 357.59 ms
Billed Duration: 471 ms
Memory Size: 192 MB
Max Memory Used: 32 MB
Init Duration: 112.44 ms

Optimised for Speed

Package size: 12.0 MB

First Sample

Duration: 325.20 ms
Billed Duration: 436 ms
Memory Size: 192 MB
Max Memory Used: 31 MB
Init Duration: 110.76 ms

Second Sample

Duration: 304.55 ms
Billed Duration: 423 ms
Memory Size: 192 MB
Max Memory Used: 31 MB
Init Duration: 118.34 ms

Remove redundant options from move to native AoT.
@martincostello
Copy link
Owner Author

/deploy dev

Copy link

github-actions bot commented Dec 1, 2023

🧪 Tests for deployment to dev passed ✅

@martincostello martincostello marked this pull request as ready for review December 1, 2023 09:02
@martincostello martincostello merged commit bcac20b into main Dec 1, 2023
11 of 13 checks passed
@martincostello martincostello deleted the martincostello-patch-1 branch December 1, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant