tests: Hack Gentoo build #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About a month ago, vala fell out of umockdev's build dependencies. Explicitly install it.
|
OK, timeout -- I'll keep Gentoo CI alive with that hack, and if it deteriotates further I'll drop it again. (No offense meant, just want to keep stuff green, and take the urgency out) |
|
Sorry, not ignoring you, just not had time to look at this properly yet -- the tab is open for me to come to! The workaround is fine. |
|
@thesamesam Thanks! No worries, I'd just like to make the regular test runs green again, that turns this from "urgent" to "nice to have". I'm aware that we are all doing this in our spare time 😁 Of course I'm happy to revise this hack later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About a month ago, vala fell out of umockdev's build dependencies. Explicitly install it.
@thesamesam @mattst88: Do you happen to know why valac does not get installed any more? It used to be part of
in the run-gentoo test script, but that doesn't happen any more. This was introduced by @mattst88 in ed29c01 and basically unchanged since then, other than the binary package optimization in commit 6a1d57a.
I can hack around it like in this PR by installing it explicitly, but that feels bad -- vala very much needs to be a build dependency of umockdev. Is that invocation wrong? Any help appreciated, thanks!