feat: extend twitter api - initial commit #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvin-reyes
requested review from
a team,
mcamou,
mudler and
restevens402
and removed request for
a team
mcamou
previously requested changes
Jan 24, 2025
There was a problem hiding this comment.
Some thoughts on the design of the API, and why include count when we don't have a chance to paginate. Also some additional points.
Regarding the tests, I've added some suggestions. In short:
-
Always check the error after unmarshalling. This will catch some breaking changes in the Twitter schema (not all, but something is better than nothing).
-
Use
Expect(x).ToNot(BeEmpty())instead ofExpect(len(x)).ToNot(BeZero()). This should result in slightly better error messages if the test fails.
There are one or two additional suggestions in the tests. I would also recommend, if you can, changing the other tests in thtwitter_test.go accordingly.
alvin-reyes
dismissed
mcamou’s stale review
resolved the review pointed on the latest commit.
mcamou
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the twitter api based on the requirements here https://github.com/masa-finance/issues/issues/217.
This also bumps the tee-worker to use masa's own fork of twitter-scraper.