Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the stats/telemetry job, and add initial job docs to the README (https://github.com/masa-finance/issues/issues/216) #19

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add the stats/telemetry job, and add initial job docs to the README (https://github.com/masa-finance/issues/issues/216) #19

merged 1 commit into from
Feb 5, 2025

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Jan 29, 2025

No description provided.

@mcamou mcamou marked this pull request as draft January 29, 2025 15:39
@mcamou mcamou force-pushed the mc/telemetry-job branch 6 times, most recently from 0ca9893 to fd1f385 Compare January 30, 2025 16:56
@mcamou mcamou marked this pull request as ready for review January 31, 2025 17:57
@mcamou mcamou requested review from mudler and alvin-reyes February 1, 2025 12:16
@mcamou mcamou force-pushed the mc/telemetry-job branch 4 times, most recently from d1ede6b to 3aa9915 Compare February 4, 2025 17:29
@mcamou mcamou requested a review from alvin-reyes February 4, 2025 18:39
alvin-reyes
alvin-reyes approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Be good if we can add unit tests but that can be on a separate PR.

@mcamou
Add the telemetry/stats job (masa-finance/issues#216)
c1af902 
Add initial job docs to the README

Refactoring and simplification

Fix compilation errors

Fix failing tests

Add tests

Fix some tests

PR comments

PR comments

Test fixes
@mcamou
Copy link
Contributor Author

mcamou commented Feb 5, 2025

LGTM. Be good if we can add unit tests but that can be on a separate PR.

I decided that unit tests were not necessary, since the assertions I added to the existing tests already test that this works. You don't agree?

@mcamou mcamou merged commit b6e313f into main Feb 5, 2025
2 checks passed
@mcamou mcamou deleted the mc/telemetry-job branch February 5, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@mudler mudler Awaiting requested review from mudler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcamou @alvin-reyes