-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add expiration logs #99
add expiration logs #99
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 99.57% 99.54% -0.03%
==========================================
Files 76 76
Lines 5819 5890 +71
==========================================
+ Hits 5794 5863 +69
- Misses 25 27 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
log.read_and_writeをfor文で回すのは筋が悪いので、bulk_read_ane_writeを作ろうと思います。 こっちは意外と対処がむずいので、一旦置いておくことにします。loggerを直接触ればいいという説もあるのですが、それをすると、log側で書き込み時にhookすることが難しくなるので、ちょっと用検討です。(hookが必要なシーンというのは実際問題ないのですが...) |
ExpirationLog
inlogs.base
.Logger.process_expiration_log
method.OrderBook._check_expired_orders()
andOrderBook._set_time()
have been changed to return a list of expiration logs.Market._set_time()
andMarket._update_time()
have been changed to read and write expiration logs internally.