Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expiration logs #99

Conversation

ryuji-hashimoto0110
Copy link

@ryuji-hashimoto0110 ryuji-hashimoto0110 commented Apr 7, 2024

  • add ExpirationLog in logs.base.
  • add Logger.process_expiration_log method.
  • OrderBook._check_expired_orders() and OrderBook._set_time() have been changed to return a list of expiration logs.
  • Market._set_time() and Market._update_time() have been changed to read and write expiration logs internally.

@ryuji-hashimoto0110 ryuji-hashimoto0110 changed the title Hashimoto/expiration log add expiration logs Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.54%. Comparing base (e71f357) to head (f7505cd).

❗ Current head f7505cd differs from pull request most recent head 9f6361e. Consider uploading reports for the commit 9f6361e to get more accurate results

Files Patch % Lines
pams/market.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   99.57%   99.54%   -0.03%     
==========================================
  Files          76       76              
  Lines        5819     5890      +71     
==========================================
+ Hits         5794     5863      +69     
- Misses         25       27       +2     
Flag Coverage Δ
pytest 99.54% <97.43%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masanorihirano masanorihirano changed the base branch from main to release/0.2.1 April 7, 2024 08:08
@masanorihirano
Copy link
Owner

  • log.read_and_writeをfor文で回すのは筋が悪いので、bulk_read_ane_writeを作ろうと思います。
  • カバレッジに関しては、2行カバーされていないので、修正をします。
    が、一旦、リリース用のブランチを作ってそこにマージしてから作業しますので、このPRはそこにマージします。

@masanorihirano masanorihirano merged commit d908fea into masanorihirano:release/0.2.1 Apr 7, 2024
15 checks passed
@masanorihirano
Copy link
Owner

log.read_and_writeをfor文で回すのは筋が悪いので、bulk_read_ane_writeを作ろうと思います。

こっちは意外と対処がむずいので、一旦置いておくことにします。loggerを直接触ればいいという説もあるのですが、それをすると、log側で書き込み時にhookすることが難しくなるので、ちょっと用検討です。(hookが必要なシーンというのは実際問題ないのですが...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants