♻ refactor(IDistributedCache): Optimize connections under Isolation and Attempt to reconnect #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capdiem
reviewed
Oct 30, 2024
|
|
||
| namespace Masa.BuildingBlocks.Caching; | ||
|
|
||
| internal class DistributedCacheClientCache |
There was a problem hiding this comment.
DistributedCacheClientCache的后缀Cache是OK的吗？你这是个工厂吧，改成ClientFactory？
capdiem
reviewed
Oct 30, 2024
| { | ||
| public static ConcurrentDictionary<string, IManualDistributedCacheClient> CacheClients { get; set; } = new(); | ||
|
|
||
| public IManualDistributedCacheClient GetCacheClient(IServiceProvider serviceProvider) |
There was a problem hiding this comment.
IHttpClientFactory用的时CreateClient，要对其它吗？
capdiem
reviewed
Oct 30, 2024
...hing/Distributed/Masa.Contrib.Caching.Distributed.StackExchangeRedis/RedisCacheClientBase.cs
Outdated
Show resolved
Hide resolved
capdiem
reviewed
Nov 25, 2024
Comment on lines
58
to
66
| if (!_connection.IsConnected && !_connection.IsConnecting) | ||
| { | ||
| return _connection.GetDatabase(); | ||
| // Attempt to reconnect | ||
| var redisConfiguration = _redisConfigurationOptions.GetAvailableRedisOptions(); | ||
| _connection = ConnectionMultiplexer.Connect(redisConfiguration); | ||
| Subscriber = _connection.GetSubscriber(); | ||
| } | ||
|
|
||
| // Attempt to reconnect | ||
| var redisConfiguration = _redisConfigurationOptions.GetAvailableRedisOptions(); | ||
| _connection = ConnectionMultiplexer.Connect(redisConfiguration); | ||
| Subscriber = _connection.GetSubscriber(); | ||
|
|
||
| if (_connection.IsConnected || _connection.IsConnecting) | ||
| { | ||
| return _connection.GetDatabase(); | ||
| } | ||
| else | ||
| if (!_connection.IsConnected && !_connection.IsConnecting) |
capdiem
approved these changes
Nov 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.