Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to answerInlineQuery and implement exportChatInviteLink method #58

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

acran
Copy link
Contributor

@acran acran commented Jan 21, 2019

  • answerInlineQuery method was missing the parameters switch_pm_text and switch_pm_parameter, see answerInlineQuery
  • exportChatInviteLink (see api docs) was not implemented yet

acran added 2 commits January 22, 2019 00:05
Not returning any value in the promise chain resulted in a warning like
this:

(node:165) Warning: a promise was created in a handler at app/node_modules/telegram-bot-api/lib/telegram-bot.js:1680:13 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (/app/node_modules/bluebird/js/release/promise.js:79:10)
@acran
Copy link
Contributor Author

acran commented Jan 25, 2019

Hey @mast, any chances on getting these changes merged into your upstream?

@mast
Copy link
Owner

mast commented Feb 1, 2019

I like this. Thanks.

@mast mast merged commit 86e0cda into mast:master Feb 1, 2019
@acran
Copy link
Contributor Author

acran commented Feb 9, 2019

Hey @mast, glad you liked it :D
Could you publish a new release to the npm registry, so I can start using it? (maybe after also having a look at my next pull request #60 ;)

acran added a commit to acran/AcademyConsultBot that referenced this pull request Feb 16, 2019
upstream enthält jetzt die Anpassungen aus
f073288 und
28d7aa9

siehe mast/telegram-bot-api#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants