Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external space changed so update test data #51

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Feb 4, 2025

what

  • Changes test data to match our new Space ID (external in the masterpointio Spacelift)

why

  • I mucked around with Spaces when integration testing this module... and then broke this as a result 😅

references

@Gowiem Gowiem self-assigned this Feb 4, 2025
@Gowiem Gowiem requested a review from a team as a code owner February 4, 2025 17:39
@Gowiem Gowiem enabled auto-merge (squash) February 4, 2025 17:39
Copy link
Member

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Gowiem Gowiem merged commit 569d8d4 into main Feb 4, 2025
4 checks passed
@Gowiem Gowiem deleted the fix/test-data branch February 4, 2025 17:40
Gowiem added a commit that referenced this pull request Feb 4, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.0.0](v0.7.0...v1.0.0)
(2025-02-04)


### ⚠ BREAKING CHANGES

* TF Version pinning has been updated to require terraform v1.9+ and
OpenTofu v1.7+. Please update the consuming root module accordingly.
(#43)
* Scopes `tfvars` + `default_tf_workspace_enabled` settings under
`automation_settings` object in StackConfig schema. [See
README](https://github.com/masterpointio/terraform-spacelift-automation?tab=readme-ov-file#what-goes-in-a-stack-config-file-eg-stacksdevyaml-stackscommonyaml-stackyaml-and-similar)
for example of StackConfig schema. (#42)

### Features

* adds support for description as a templatestring
([#43](#43))
([1bbb74f](1bbb74f))
* adds the runtime_overrides variable + tests
([#44](#44))
([6030f94](6030f94))
* feat: allow specifying `space_name` that maps to space_id #46
* **schema:** adds initial JSON schema + StackConfig changes
([#42](#42))
([f247b5e](f247b5e))


### Bug Fixes

* cron validator regex escape characters
([#45](#45))
([81a386b](81a386b))
* dont clobber static config with overrides
([#50](#50))
([b352674](b352674))
* external space changed so update test data
([#51](#51))
([569d8d4](569d8d4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Gowie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants