Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Use django-cms for most pages #92

Merged
merged 11 commits into from
Jul 10, 2020
Merged

Use django-cms for most pages #92

merged 11 commits into from
Jul 10, 2020

Conversation

Baschdl
Copy link
Contributor

@Baschdl Baschdl commented Jul 8, 2020

Provide configuration for pages in django-cms

Depends on #21
Fixes #87 and fixes #25

backend/templates/home.html Outdated Show resolved Hide resolved
backend/templates/home.html Outdated Show resolved Hide resolved
{% block header %}

<meta name="description"
content="Der Glaube daran Mitmenschen in Not helfen können, die Liebe zum Fach Medizin und der Zusammenhalt untereinander sind in den letzten Wochen und Monaten im Gesundheitswesen noch viel präsenter denn je.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is difficult to make these editable with the cms as it is not WYSIWYG. However, especially these will be edited by social media people, maybe even frequently when changing "campaign slogans" or stuff like that. Would that be possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would wanna use something like https://github.com/nephila/djangocms-page-meta or https://pypi.org/project/django-meta/. Feel free to open an issue for this

WARNINGS:
?: (map.W001) Usage restricted tile server.
HINT: You are using an open street map tile server for viewing the map, which is subject to usage restrictions (See https://operations.osmfoundation.org/policies/tiles/).
If you plan to put this system into production, please consider setting up your own tile server or using a commercial service, e.g. mapbox.We readily provide an integration for mapbox, which you can use by setting LEAFLET_TILESERVER='mapbox' and adding your API key by setting the environment variable MAPBOX_TOKEN.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D 🙈
I know this is generated automatically, but should this stay? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, I forgot to remove this. That obviously breaks the import

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this there? Are checks run on dumpdata?
Can you check if they are on STDOUT or STDERR? We might need to adapt the backup script for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are checks run on dumpdata?

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very important, but not directly related to this issue, so I opened a new one: #117

README.md Outdated Show resolved Hide resolved
@bjrne bjrne merged commit 353ed1b into staging Jul 10, 2020
@bjrne bjrne deleted the configure_django-cms branch July 10, 2020 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide initial page setup in fresh deploy CMS system for use case-specific texts
3 participants