Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Use psycogreen #98

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Use psycogreen #98

merged 4 commits into from
Jul 9, 2020

Conversation

Baschdl
Copy link
Contributor

@Baschdl Baschdl commented Jul 8, 2020

As per https://docs.gunicorn.org/en/stable/settings.html#timeout:

Generally set to thirty seconds. Only set this noticeably higher if you’re sure of the repercussions for sync workers. For the non sync workers it just means that the worker process is still communicating and is not tied to the length of time required to handle a single request.

I did some reading up on the different worker_classes and found this:

For full greenlet support applications might need to be adapted. When using, e.g., Gevent and Psycopg it makes sense to ensure psycogreen is installed and setup.

https://docs.gunicorn.org/en/stable/design.html

I think with async workers normally you shouldn't see a timeout happening here, have we implemented the above or is it possible that our DB calls are still synchronous? At least in requirements we have no psycogreen (yet?)

For more details see #58

@maltezacharias
Copy link
Contributor

It seems to work, that is really all I can say :D

@maltezacharias maltezacharias merged commit bd74662 into staging Jul 9, 2020
@maltezacharias maltezacharias deleted the use_psycogreen branch July 9, 2020 21:34
@@ -1,5 +1,6 @@
gevent==1.5.0
gunicorn==20.0.4
psutil==5.7.0
psycogreen==1.0.2
psycopg2==2.8.5
psycopg2==2.8.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a weird merge?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one obviously only added psycogreen==1.0.2 but the duplication of psycopg is indedd strange

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants