stage interface improvement for stages #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
============================================
+ Coverage 96.06% 96.08% +0.01%
- Complexity 192 193 +1
============================================
Files 36 36
Lines 636 638 +2
============================================
+ Hits 611 613 +2
Misses 25 25
☔ View full report in Codecov by Sentry. |
|
I could not understand what is the problem exactly with |
|
Ahh I see. New lines 😭 Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initialize a StageInterface to implement in stages. This is not like an improvement on logic but would be great for code structure. And if somebody want to add some extra custom stages, they can implement with using this interface.