Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add php 8.3 compatibility #266

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

jackraymund
Copy link
Contributor

@jackraymund jackraymund commented Nov 29, 2023

As in ticket
#265

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ddc0d97) 96.08% compared to head (1b4b596) 96.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #266   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
  Complexity      193      193           
=========================================
  Files            36       36           
  Lines           638      638           
=========================================
  Hits            613      613           
  Misses           25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matchish
Copy link
Owner

Could you add 8.3 to matrix as well?
https://github.com/matchish/laravel-scout-elasticsearch/blob/master/.github/workflows/test-application.yaml

@jackraymund
Copy link
Contributor Author

@matchish matchish merged commit 00e3caf into matchish:master Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants