Allow setting source (fields) from options #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for late answer. could you pull master to resolve failed checks |
hulkur
force-pushed
the
source_option
branch
from
1a4de24 to
8046db9
Compare
|
done, checks pass. |
|
cool. could you update README and CHANGELOG as well please? |
|
I propose 7.10.0 next release |
|
What do you think about checking the options['source'] is array or not? I am sure that it will throw an error. Do we need to check it or just need to assume. Ar least we can put a test in test cases with note 🧐 |
|
|
|
This is unfortunate. |
|
Released. Thanks for contribution @hulkur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you want to limit returned fields.
Use case: search index has added custom fields that are searched but should not be returned in results