Develop #342

oltarasov · 2023-09-29T14:26:25Z

DEMO LINK

andriy-shymkiv

-background color not like in design:

layout is jumping when I open/close the menu:
give hover for the images like this:
what is this? please fix it:
the layout is broken here:
and it is jumping when I click on imputs:
remove this line:
on desktop it is broken as well:

nazarmatsevych

Well done, just minor comments to be fixed:

add scroll-behavior: smooth to make scroll animation smooth
Add type email to email field and make both fields required
Change 2019 to 2023

nazarmatsevych

The page should not reload on submit, also clear form fields on the button click

Here are how you could achieve that

anastasiiavorobiova

Great work! Let's make it perfect:

Consider fixing the validation error

The image looks skewed

Check font styling here

Space between sections should be added

The user should be able to scroll the menu in the landscape mode

The redundant space should be removed

Check fonts here

Titles should be aligned differently to meet the Figma design

Add cursor pointer to the interactive elements

The elements should be aligned according to the Figma design

anastasiiavorobiova · 2023-10-01T13:34:14Z

src/index.html

+    <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap"
+      rel="stylesheet">


Suggested change

<link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap"

rel="stylesheet">

<link

href="https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap"

rel="stylesheet"

>

Consider fixing indentations according to the code style guide

anastasiiavorobiova · 2023-10-01T13:37:47Z

src/index.html

+          <img class="benefits__logo" src="./images/design2.svg"
+            alt="design2"
+          >


Suggested change

<img class="benefits__logo" src="./images/design2.svg"

alt="design2"

>

<img

class="benefits__logo"

src="./images/design2.svg"

alt="design2"

>

anastasiiavorobiova · 2023-10-01T13:38:09Z

src/index.html

+          <img class="benefits__logo" src="./images/design3.svg"
+            alt="design3"
+          >


Suggested change

<img class="benefits__logo" src="./images/design3.svg"

alt="design3"

>

<img

class="benefits__logo"

src="./images/design3.svg"

alt="design3"

>

anastasiiavorobiova · 2023-10-01T13:38:26Z

src/index.html

+          <img class="benefits__logo" src="./images/design4.svg"
+            alt="design4"
+          >


Suggested change

<img class="benefits__logo" src="./images/design4.svg"

alt="design4"

>

<img

class="benefits__logo"

src="./images/design4.svg"

alt="design4"

>

anastasiiavorobiova · 2023-10-01T13:38:42Z

src/index.html

+        <img class="meet-luna__image" src="./images/meetluna.png"
+          alt="MEETLUNA"
+        >


Suggested change

<img class="meet-luna__image" src="./images/meetluna.png"

alt="MEETLUNA"

>

<img

class="meet-luna__image"

src="./images/meetluna.png"

alt="MEETLUNA"

>

anastasiiavorobiova · 2023-10-01T13:40:35Z

src/index.html

+        <img class="footer__link-back-home__image" src="./images/icon/vector.svg"
+          alt="vect"
+        >


Suggested change

<img class="footer__link-back-home__image" src="./images/icon/vector.svg"

alt="vect"

>

<img

class="footer__link-back-home__image"

src="./images/icon/vector.svg"

alt="vect"

>

anastasiiavorobiova · 2023-10-01T13:40:48Z

src/index.html

+        <a class="footer__icon" href="https://www.facebook.com/"
+          target="_blank"
+        >


Suggested change

<a class="footer__icon" href="https://www.facebook.com/"

target="_blank"

>

<a

class="footer__icon"

href="https://www.facebook.com/"

target="_blank"

>

anastasiiavorobiova · 2023-10-01T13:41:05Z

src/index.html

+        <a class="footer__icon" href="https://twitter.com/"
+          target="_blank"
+        >


Suggested change

<a class="footer__icon" href="https://twitter.com/"

target="_blank"

>

<a

class="footer__icon"

href="https://twitter.com/"

target="_blank"

>

anastasiiavorobiova · 2023-10-01T13:41:27Z

src/index.html

+        <a class="footer__icon" href="https://www.instagram.com/"
+          target="_blank"
+        >


Suggested change

<a class="footer__icon" href="https://www.instagram.com/"

target="_blank"

>

<a

class="footer__icon"

href="https://www.instagram.com/"

target="_blank"

>

anastasiiavorobiova · 2023-10-01T13:41:54Z

src/scripts/main.js

+  function showSlide(index) {
+    slides.forEach((slide, i) => {
+      // slide.style.display = i === index ? 'block' : 'none';
+    });


If you don't need this cycle you can delete it

anastasiiavorobiova

Great progress! https://www.loom.com/share/2fae37dcf1f04cdf88f3419170c7bea3?sid=e6df1367-641e-48bf-95bc-ca58d0bf31f7

IvanFesenko

Fix this case -
https://github.com/mate-academy/Kickstarter/assets/61904995/1add2f6e-9fb9-417b-9b65-6091a584bdf4

oltarasov added 4 commits September 21, 2023 12:03

landing test deploy v1

f069076

landing deploy test v1.2

dcf94f6

test deploy v11

df9f29f

kickstarter landing v1

a0c9541

andriy-shymkiv suggested changes Sep 29, 2023

View reviewed changes

kickstarter landing v1.2

7c66ba6

oltarasov requested a review from andriy-shymkiv October 1, 2023 09:06

nazarmatsevych suggested changes Oct 1, 2023

View reviewed changes

oltarasov added 2 commits October 1, 2023 14:13

Kickstarter landing v1.3

10dce79

Kickstarter landing v1.4

ec1f33a

oltarasov requested a review from nazarmatsevych October 1, 2023 11:26

nazarmatsevych suggested changes Oct 1, 2023

View reviewed changes

Kickstarter landing v1.5

bb0fdb8

oltarasov requested a review from nazarmatsevych October 1, 2023 11:59

anastasiiavorobiova suggested changes Oct 1, 2023

View reviewed changes

Kickstarter landing v1.6

1eed52a

oltarasov requested a review from anastasiiavorobiova October 2, 2023 09:32

anastasiiavorobiova suggested changes Oct 2, 2023

View reviewed changes

Kickstarter landing v2

4f5a664

oltarasov requested a review from anastasiiavorobiova October 2, 2023 12:14

IvanFesenko suggested changes Oct 2, 2023

View reviewed changes

Kickstarter landing final

c6388da

oltarasov requested a review from IvanFesenko October 2, 2023 15:10

sTorba24 approved these changes Oct 2, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop #342

Develop #342

oltarasov commented Sep 29, 2023

andriy-shymkiv left a comment •

edited

Loading

nazarmatsevych left a comment

nazarmatsevych left a comment

anastasiiavorobiova left a comment

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova Oct 1, 2023

anastasiiavorobiova left a comment

IvanFesenko left a comment

		<link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;700&display=swap"
		rel="stylesheet">

Develop #342

Are you sure you want to change the base?

Develop #342

Conversation

oltarasov commented Sep 29, 2023

andriy-shymkiv left a comment • edited Loading

Choose a reason for hiding this comment

nazarmatsevych left a comment

Choose a reason for hiding this comment

nazarmatsevych left a comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

IvanFesenko left a comment

Choose a reason for hiding this comment

andriy-shymkiv left a comment •

edited

Loading