Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added task solution #349

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Zaransoftline
Copy link

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but lets make some improvement

  1. when i hover on it other links are jumping
    image
    2.would be nice to add some hover here
    image
    image

3.its must be a link
image
4. you must to add validation to your form for email and must not refresh page after submit
5.here must be hover effect and link
image
6. check why it happened
image
7. looks like something missing fix its somehow
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2023-10-14 at 09 58 00
Consider using the button here
Screenshot 2023-10-14 at 10 00 22

The styling for devices looks different from Figma, consider fixing it
Screenshot 2023-10-14 at 10 00 22
Screenshot 2023-10-14 at 10 00 31
Screenshot 2023-10-14 at 10 02 58
The user should be able to scroll the menu
Screenshot 2023-10-14 at 10 02 10

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add the actual title on the page
image
  1. Add hover effects and cursor pointer for all clickable elements
image
  1. Add validation for the email
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
Writing all styles in one file is not a very good practice, you need to separate it into separate files for better readability

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2023-10-17 at 13 41 25
Not fixed from the previous review
Screenshot 2023-10-17 at 13 38 40
Screenshot 2023-10-17 at 13 39 11
Screenshot 2023-10-17 at 13 39 53
The quantity and the layout of these blocks don't meet the Figma breakpoints

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants