Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #353

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Develop #353

wants to merge 11 commits into from

Conversation

boytrend0108
Copy link

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2023-10-23 at 14 28 34
Add a favicon
Screenshot 2023-10-23 at 14 29 44
Check fonts here
Screenshot 2023-10-23 at 14 30 03
The navigation jumps a bit while hovering
Screenshot 2023-10-23 at 14 31 48
Check the button styles and the current language should be styled differently
Screenshot 2023-10-23 at 14 32 22
A user should be able to scroll the menu and see a button
Screenshot 2023-10-23 at 14 34 06
Check the size of the menu. Also, there is a horizontal scroll on mobiles and tablets, consider fixing it

Copy link

@denys-danyliuk denys-danyliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase whole block on hover because now you can barely see that it's changing on hover
Знімок екрана 2023-10-23 о 17 03 07

8'th point in checklist, add cursor pointer
Знімок екрана 2023-10-23 о 17 04 49

12'th point in checklist
Знімок екрана 2023-10-23 о 17 05 31

arrows in slider doesn't work right, right one change element to the previous one instead on next one, and left one work as right should

Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants