Develop #356
Develop #356
Conversation
OstinM
commented
Oct 25, 2023
OstinM
commented
- DEMO LINK
There was a problem hiding this comment.
Good job, but there is quite a bit of work to be done.
According to the task, you must have certain mandatory sections, which are not all present at the moment (it is enough to change the naming):
The element for changing the language should appear in one line:
The "Send" button should not take us anywhere at the moment:
https://gyazo.com/fdc2aaf3f162dc922e28eeac190160bf
src/styles/blocks/about-us.scss
Outdated
| @include onDeskTop { | ||
| @include hover(transform, scale(105%)); | ||
| } | ||
|
|
src/styles/blocks/comments.scss
Outdated
| grid-column: span 12; | ||
| } | ||
|
|
||
| // column-gap: 30px; |
There was a problem hiding this comment.
Do not leave unnecessary comments.
| &__info-list { | ||
| padding-inline: 30px; | ||
| margin: 0 0 50px 14px; | ||
| @include onTablet { |
There was a problem hiding this comment.
| @include onTablet { | |
| @include onTablet { |
src/styles/blocks/features.scss
Outdated
| grid-column: 1/ 5; | ||
| margin: 0 0 0 14px; | ||
| padding: 0; | ||
|
|
src/styles/blocks/features.scss
Outdated
|
|
||
|
|
src/styles/utils/_vars.scss
Outdated
| $c-gray: #eee; | ||
| $c-menu-item: #f9f9f9; | ||
| $c-white: #fff; | ||
| $main-text-c: #000; | ||
| $second-text-c: #7c7c7c; | ||
| $btn-c: #333; | ||
| $btn-hover: #131313; | ||
| $page-background-c: #f7f7f7; | ||
| $see-more-link-c:#0db2b3; | ||
| $contarast-c: #d6ecec; | ||
| $dark-green-c: #0c797a; | ||
| $form-border-c:#828282; | ||
| $placeholder-c: #bdbdbd; | ||
| $disabled-btn-c: #d0d0d0; | ||
| $submit-btn-c: #39bebf; |
There was a problem hiding this comment.
Do not abbreviate the names of variables to unreadable ones and try to minimally use naming according to the content (that is, if you want to keep the color white, do not make the variable white-color, but name it more universally)
src/index.html
Outdated
| <img | ||
| src="./images/features-vector-photo.svg" | ||
| alt="features vector photo" | ||
| class="features__vector-photo" | ||
| > |
There was a problem hiding this comment.
Don't forget about good code formatting.
| <h3 class="features__second-title features__second-title--hidden"> | ||
| Connectivity | ||
| </h3> | ||
|
|
src/index.html
Outdated
| <div class="features__bottom"> | ||
| <img | ||
| src="./images/features-background.png" | ||
| alt="features__background-img" |
There was a problem hiding this comment.
The alt attribute contains information that will be displayed if the photo cannot be loaded, as well as voiced by the screen reader, so there should be a description of what the image contains.
src/index.html
Outdated
| class="features__background-img" | ||
| > | ||
| </div> | ||
|
|
