Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #457

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Develop #457

wants to merge 7 commits into from

Conversation

AlbinaAlbi
Copy link

VitaliyBondarenko1982
VitaliyBondarenko1982 suggested changes Oct 20, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo link leads on 404 page.
Looks like wasn't any deploy for this repo
https://github.com/AlbinaAlbi/Kickstarter/actions

etojeDenys
etojeDenys suggested changes Oct 21, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image looks different
image
image

  1. disable the scroll when menu is open
  2. stretch the buy button in the menu
image

@AlbinaAlbi AlbinaAlbi requested a review from etojeDenys October 22, 2024 07:46
volodymyr-soltys97
volodymyr-soltys97 suggested changes Oct 22, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the first comment from the previous review still not fixed
image

etojeDenys
etojeDenys approved these changes Oct 22, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@VitaliyBondarenko1982 VitaliyBondarenko1982 Awaiting requested review from VitaliyBondarenko1982

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbinaAlbi @VitaliyBondarenko1982 @volodymyr-soltys97 @etojeDenys